InterpreterFrom and ActorRefFrom types used on machines with typegen data should now correctly return types with final/resolved typegen data
#3139
Conversation
…gen data should now correctly return types with final/resolved typegen data
🦋 Changeset detectedLatest commit: 0b5f79e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b5f79e:
|
| TStateSchema, | ||
| TEvent, | ||
| TTypestate, | ||
| MarkAllImplementationsAsProvided<TResolvedTypesMeta> |
There was a problem hiding this comment.
The crucial bit is to use MarkAllImplementationsAsProvided here.
It shouldn't be possible to "start"/create a service/actor without providing all implementations first. So this thing should be impossible to create as interpret won't allow it:
Interpreter<TContext, any, TEvent, any, TypegenMetaStillExpectingSomeImplementations>Therefore, it makes sense to just mark those as provided here as wherever you might use InterpreterFrom<typeof machine> you should only be able to receive valid interpreters (and that is ones with all implementations marked as provided)
fixes #3138
cc @SimeonC