-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] Remove createModel
#3187
[v5] Remove createModel
#3187
Conversation
🦋 Changeset detectedLatest commit: 460826a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 460826a:
|
👇 Click on the image for a new way to code review
Legend |
@@ -55,7 +55,6 @@ | |||
"./actions.ts", | |||
"./invoke.ts", | |||
"./behaviors.ts", | |||
"./model.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the migration strategy that we will offer to people? Should we think about a codemod? Should we hand the model API to the community so they could publish and maintain a drop-in replacement package? Or do we propose to use a replacement snippet akin to this one (note that this doesn't actually contain runtime event factories, but that can be added to it) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration will be part of v4 and not this PR. We will first have to mark it as deprecated in v4, and point to using schema
instead.
This RFC is relevant: statelyai/rfcs#12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a changeset here 😉
We should mark this as deprecated in v4, right? |
Yes, good catch. Need to figure out a good migration strategy first though 🤔 |
0c89c96
to
98a7202
Compare
Closes STA-1275