Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Remove createModel #3187

Merged
merged 5 commits into from
Jun 8, 2022
Merged

[v5] Remove createModel #3187

merged 5 commits into from
Jun 8, 2022

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Mar 30, 2022

Closes STA-1275

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: 460826a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Mar 30, 2022

STA-1275

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 460826a:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Mar 30, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@@ -55,7 +55,6 @@
"./actions.ts",
"./invoke.ts",
"./behaviors.ts",
"./model.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the migration strategy that we will offer to people? Should we think about a codemod? Should we hand the model API to the community so they could publish and maintain a drop-in replacement package? Or do we propose to use a replacement snippet akin to this one (note that this doesn't actually contain runtime event factories, but that can be added to it) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration will be part of v4 and not this PR. We will first have to mark it as deprecated in v4, and point to using schema instead.

This RFC is relevant: statelyai/rfcs#12

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changeset here 😉

@mattpocock
Copy link
Contributor

We should mark this as deprecated in v4, right?

@davidkpiano
Copy link
Member Author

We should mark this as deprecated in v4, right?

Yes, good catch. Need to figure out a good migration strategy first though 🤔

@Andarist Andarist force-pushed the next branch 2 times, most recently from 0c89c96 to 98a7202 Compare May 26, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants