Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix sendTo types #3238

Merged
merged 3 commits into from
Apr 21, 2022
Merged

[core] Fix sendTo types #3238

merged 3 commits into from
Apr 21, 2022

Conversation

davidkpiano
Copy link
Member

This PR fixes the wrong typings in sendTo(...).

@davidkpiano davidkpiano linked an issue Apr 20, 2022 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

🦋 Changeset detected

Latest commit: 3df6335

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Apr 20, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b956a84:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@@ -708,7 +708,7 @@ describe('entry/exit actions', () => {
});

const service = interpret(machine).start();
// it's important to send an event here that results in a transition as that computes new `state.configuration`
// it's important to send an event here that results in a transition that computes new `state.configuration`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when Find and Replace goes too far 🤣

@davidkpiano davidkpiano merged commit bf3f852 into main Apr 21, 2022
@davidkpiano davidkpiano deleted the 3236-bug-incorrect-sendto-typing branch April 21, 2022 15:06
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/xstate that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect sendTo() typing
2 participants