Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with parallel region reentrancy #3422

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Andarist
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

🦋 Changeset detected

Latest commit: 5386d60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Jun 23, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5386d60:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@@ -1608,7 +1608,7 @@ class StateNode<
return this.resolveTransition(
{
configuration,
entrySet: configuration,
entrySet: [...configuration],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I've added another situation in which transition.entrySet might be mutated I had to make a copy here to avoid configuration being affected by this mutation. This was required by this test:

it('should call each exit handler only once when the service gets stopped', () => {
const actual: string[] = [];
const machine = createMachine({
exit: () => actual.push('root'),
initial: 'a',
states: {
a: {
exit: () => actual.push('a'),
initial: 'a1',
states: {
a1: {
exit: () => actual.push('a1')
}
}
}
}
});
interpret(machine).start().stop();
expect(actual).toEqual(['a1', 'a', 'root']);
});

Without this line it was calling exit actions multiple times as the mutated configuration contained duplicated state nodes

@Andarist Andarist force-pushed the andarist/fix-parallel-region-reentering branch from 1eff5ca to 5386d60 Compare June 23, 2022 14:57
@Andarist Andarist merged commit e35493f into main Jun 24, 2022
@Andarist Andarist deleted the andarist/fix-parallel-region-reentering branch June 24, 2022 06:46
@github-actions github-actions bot mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants