Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Remove autoForward #3889

Merged
merged 7 commits into from
Mar 24, 2023
Merged

[v5] Remove autoForward #3889

merged 7 commits into from
Mar 24, 2023

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Mar 13, 2023

The recommended pattern moving forward would be to explicitly sendTo(...) events to actors.

There are still some SCXML tests that depend on autoForward. XState will no longer support autoForward in SCXML.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: 234d416

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Mar 13, 2023

STA-3440

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 234d416:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Mar 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Base automatically changed from v5/recursive-persistence to next March 14, 2023 12:04
@davidkpiano davidkpiano changed the title [v5] Remove autoForward, mostly [v5] Remove autoForward Mar 14, 2023
@Andarist Andarist force-pushed the v5/sta-3440-remove-autoforward branch from 85548f3 to 8c52329 Compare March 22, 2023 12:24
Andarist and others added 3 commits March 22, 2023 13:44
* Remove more `autoForward` leftovers

* Remove unused import
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@Andarist Andarist force-pushed the v5/sta-3440-remove-autoforward branch from fb70dac to c21e2eb Compare March 24, 2023 00:06
…toforward

# Conflicts:
#	packages/core/test/invoke.test.ts
@Andarist Andarist merged commit b394cf1 into next Mar 24, 2023
@Andarist Andarist deleted the v5/sta-3440-remove-autoforward branch March 24, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants