Root out SCXML-related wrappers #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19fa892 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19fa892:
|
# Conflicts: # packages/core/src/actions.ts # packages/core/src/actions/raise.ts # packages/core/src/actions/send.ts # packages/core/src/interpreter.ts # packages/xstate-test/src/utils.ts
davidkpiano
reviewed
Apr 29, 2023
davidkpiano
reviewed
May 11, 2023
packages/core/src/StateMachine.ts
Outdated
| ) { | ||
| throw scxmlEvent.data.data; | ||
| throw (event as any).data; |
There was a problem hiding this comment.
Suggested change
| throw (event as any).data; | |
| // TODO: type as an error event | |
| throw (event as any).data; |
davidkpiano
reviewed
May 11, 2023
packages/core/src/actors/promise.ts
Outdated
Comment on lines
41
to
48
| data: (event as any).data, | ||
| input: undefined | ||
| }; | ||
| case rejectEventType: | ||
| return { | ||
| ...state, | ||
| status: 'error', | ||
| data: eventObject.data, | ||
| data: (event as any).data, |
There was a problem hiding this comment.
Are the types failing here?
There was a problem hiding this comment.
managed to fix this in a different way now, thanks for the call out
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.