Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with a referenced action responding to an initial raised event being called with init event #3981

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Apr 25, 2023

Related to #3979 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: 7d931c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -3572,3 +3572,48 @@ describe('action meta', () => {
interpret(machine).start();
});
});

it('should call an inline action responding to an initial raise with the raised event', () => {
Copy link
Member Author

@Andarist Andarist Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already working OK. I think that this shows that there is some weird thing happening in our implementation that the behavior can accidentally differ between inline and referenced actions.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d931c2:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Apr 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Andarist
Copy link
Member Author

Actually, i think there might be more bugs around this - gonna draft this to investigate further

@Andarist Andarist marked this pull request as draft April 25, 2023 09:53
@Andarist Andarist marked this pull request as ready for review April 25, 2023 18:44
@Andarist Andarist merged commit a225a47 into next Apr 25, 2023
2 checks passed
@Andarist Andarist deleted the event-arg-in-referenced-actions branch April 25, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants