Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to define delayed transitions using an array #4216

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: d8baad5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +383 to +385
types: {} as {
events: { type: 'FIRE_DELAY'; value: number };
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that this was needed~. I will recheck why the changes here made the raise in this machine to error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I'm not sure what has changed here but the change isn't bad per se so I'm inclined to just leave this as-is

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8baad5:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@ghost
Copy link

ghost commented Aug 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Andarist Andarist merged commit 04cad53 into next Oct 16, 2023
1 of 2 checks passed
@Andarist Andarist deleted the remove-array-delayed-transitions branch October 16, 2023 12:53
audionerd pushed a commit to audionerd/xstate that referenced this pull request Oct 19, 2023
…elyai#4216)

* Remove the ability to define delayed transitions using an array

* Add a changeset
audionerd pushed a commit to audionerd/xstate that referenced this pull request Oct 19, 2023
…elyai#4216)

* Remove the ability to define delayed transitions using an array

* Add a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants