Avoid selecting always transitions when the preceeding transition doesn't change the state #4371
Conversation
🦋 Changeset detectedLatest commit: 7034df5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7034df5:
|
Andarist
changed the title
| @@ -1621,7 +1626,7 @@ export function macrostep( | |||
| false, | |||
| internalQueue | |||
| ); | |||
|
|
|||
| shouldSelectEventlessTransitions = nextState !== previousState; | |||
There was a problem hiding this comment.
It's worth noting that this also checks non-always transitions here. This check also doesn't cover the first selectTransitions+microstep within this macrostep.
To be more consistent we should either:
- check the same for that first
microstep - or only check this after executing an
alwaystransition
Which one sounds better to you?
There was a problem hiding this comment.
I think "or only check this after executing an always transition" sounds better
There was a problem hiding this comment.
I agree and I've pushed out an according change
…tatelyai/xstate into ignore-same-always-transitions
No description provided.