Stop calling exit actions on stop #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ffd5cc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ffd5cc4:
|
davidkpiano
approved these changes
Oct 20, 2023
Base automatically changed from
fix/exit-actions-called-too-many-times
to
next
October 20, 2023 13:45
Andarist
force-pushed
the
stop-calling-exit-actions-on-stop
branch
from
4dec2cf
to
43557df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important for rehydration. A stopped aka persisted machine can't call its exit actions if we don't call entry actions later on when rehydrating that state. And we can't call those entry actions because we have no sensible
eventto call them with. In addition to that - the whole persisting/rehydrating cycle should be mostly transparent to the user and if we call those actions it's no longer transparent.Originally, we only started to call those actions in this situation because it was what SCXML mandated. It didn't come from a user request.