Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose InteropObservable and InteropSubscribable #4712

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Expose InteropObservable and InteropSubscribable #4712

merged 7 commits into from
Jan 31, 2024

Conversation

davidkpiano
Copy link
Member

@davidkpiano davidkpiano commented Jan 30, 2024 •
edited by Andarist

closes #4711

@davidkpiano davidkpiano linked an issue Jan 30, 2024 that may be closed by this pull request
Bug: Type Declarations in xstate package seem to be erroneous #4711
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited

🦋 Changeset detected

Latest commit: 7e1435b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 30, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ddf637:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@davidkpiano
Copy link
Member Author

@Andarist Can you quickly check if any other types I marked as @internal should really be @hidden? Or is it most of them?

@Andarist
Copy link
Member

Andarist commented Jan 31, 2024 •
edited

I only identified MachineImplementationsSimplified as one extra type that was erroneously marked as @internal (and pushed out a change to make it @hidden)

davidkpiano and others added 3 commits January 31, 2024 15:18
@davidkpiano @Andarist
Update packages/core/src/types.ts
f0e73e2 
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano @Andarist
Update packages/core/src/types.ts
534e7fb 
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano @Andarist
Update .changeset/slow-swans-punch.md
7e1435b 
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano
Copy link
Member Author

Changes applied; good to go?

@Andarist Andarist merged commit 2f1d36a into main Jan 31, 2024
2 checks passed
@Andarist Andarist deleted the davidkpiano/4711-bug-type-declarations-in-xstate-package-seem-to-be-erroneous branch January 31, 2024 21:29
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Type Declarations in xstate package seem to be erroneous
2 participants
@davidkpiano @Andarist