Fixed types compatibility with TS 5.0 #4728
Conversation
🦋 Changeset detectedLatest commit: 0d005f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d005f2:
|
| }[undefined extends TActor['id'] // if not all actors have literal string IDs then we need to create an index signature containing all possible actor types | ||
| ? 'include' | ||
| : string extends TActor['id'] | ||
| : Compute< |
There was a problem hiding this comment.
This just brings back Compute here so it's essentially a revert of this change https://github.com/statelyai/xstate/pull/4706/files#r1467593357
| @@ -61,7 +61,7 @@ type ToProvidedActor< | |||
| id: IsNever<TChildrenMap> extends true | |||
| ? string | undefined | |||
| : K extends keyof Invert<TChildrenMap> | |||
| ? Invert<TChildrenMap>[K] | |||
| ? Invert<TChildrenMap>[K] & string | |||
There was a problem hiding this comment.
this is the true and correct fix for what I previously fixed by removing Compute. You can read my breakdown of the issue here
No description provided.