Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 5.4 #4789

Merged
merged 5 commits into from
Mar 11, 2024
Merged

TypeScript 5.4 #4789

merged 5 commits into from
Mar 11, 2024

Conversation

davidkpiano
Copy link
Member

This PR updates the TypeScript version in the XState monorepo to 5.4, which includes replacing NoInfer with the native NoInfer (doesn't work yet)

Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: ba711df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Mar 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Andarist
Copy link
Member

Andarist commented Mar 7, 2024

We cant easily replace our NoInfer with the native one because we’d break consumers using other TS versions.

@davidkpiano davidkpiano merged commit 052da54 into main Mar 11, 2024
2 checks passed
@davidkpiano davidkpiano deleted the davidkpiano/ts-5.4 branch March 11, 2024 11:48
version "5.2.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.2.2.tgz#5ebb5e5a5b75f085f22bc3f8460fba308310fa78"
integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==

typescript@^5.4.2:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason we now have two TS versions installed - I hope it wont create problems, it would be great to deduplicate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants