Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add dev-time warning for events sent before actor is started #4794

Closed
wants to merge 1 commit into from

Conversation

davidkpiano
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: a83247c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Comment on lines +687 to +691
if (this._processingStatus === ProcessingStatus.NotStarted) {
console.warn(
`Event "${event.type}" sent to actor "${this.id}" before it started. Remember to call \`actor.start()\` before sending events.`
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good warning when it's applied like this. Sending events like this is totally legal - I'm pretty sure that we do this in our tests and that the CI might quickly fail because of this.

But it's not only about our test suite. Sending from a child effect to the parent would start warning (it's not desired) since it happens before the parent's effect runs (so before it has its chance to start the target actor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants