Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types Improvement: prevent deep _parent access (a TODO fix) #4800

Closed

Conversation

korniychuk
Copy link

 self._parent._parent

Screenshot 2024-03-15 at 14 52 00@2x

This is a suggestion, I didn't check all the side effects.

Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: a28086b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Andarist
Copy link
Member

Even shallow access is discouraged. This is a private property as denoted by the leading underscore. I prefer to avoid the Omit type when possible since it’s not the most performant type util.

I think the added benefit here doesn't justify this code change.

@Andarist Andarist closed this Mar 15, 2024
@korniychuk
Copy link
Author

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants