Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depart date bug: 7GUIs Flight Booker React #4850

Merged
merged 11 commits into from May 3, 2024

Conversation

stevebarakat
Copy link
Contributor

@stevebarakat stevebarakat commented Apr 13, 2024

  • Fixed depart date bug
  • Remodeled state machine
  • Refactored code
  • Improved UI
  • Updated screenshot
  • Added Open in StackBlitz button

Copy link

changeset-bot bot commented Apr 13, 2024

⚠️ No Changeset found

Latest commit: 834a5f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@davidkpiano
Copy link
Member

I was able to book a flight in the past

CleanShot 2024-04-15 at 13 48 48@2x

@stevebarakat
Copy link
Contributor Author

That's the old version that this pull request will update.

@stevebarakat
Copy link
Contributor Author

stevebarakat commented Apr 15, 2024

Don't use the Open in Stackblitz button to test it. It links to: https://stackblitz.com/github/statelyai/xstate/tree/main/examples/7guis-flight-booker-react, which will be the old version until the new one is merged.

@stevebarakat
Copy link
Contributor Author

Wait! Don't merge it yet. I just realized, it's supposed to display a notification confirming the flight itinerary after the flight is booked. The XState 4 example that I started this project with didn't implement that requirement but the original 7GUIs project does.

@stevebarakat
Copy link
Contributor Author

I forgot to create a different branch for this. This is Circle Drawer app on the Flight Booker branch. Here's a stackblitz for testing, if needed. https://stackblitz.com/edit/github-awfape

@stevebarakat stevebarakat changed the title Fix depart date bug: 7GUIs React Fix depart date bug: 7GUIs Flight Booker React Apr 23, 2024
@davidkpiano davidkpiano merged commit d8877fe into statelyai:main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants