[core] Add warning for imperative built-in action calls #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4be3f35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidkpiano
commented
Apr 29, 2024
| @@ -4,6 +4,7 @@ const { constants } = require('jest-config'); | |||
| * @type {import('@jest/types').Config.InitialOptions} | |||
| */ | |||
| module.exports = { | |||
| prettierPath: null, | |||
There was a problem hiding this comment.
Mitigates this error:
Jest: Inline Snapshots are not supported when using Prettier 3.0.0 or above.
There was a problem hiding this comment.
Supposedly it is fixed in Jest@30 (alpha) but 29 is still the latest version 😢
fekete965
approved these changes
Apr 29, 2024
|
Ping @Andarist |
Andarist
reviewed
May 4, 2024
Andarist
reviewed
May 4, 2024
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Andarist
reviewed
May 4, 2024
packages/core/src/stateUtils.ts
Outdated
| @@ -1550,6 +1554,7 @@ function resolveAndExecuteActionsWithContext( | |||
| : undefined; | |||
|
|
|||
| function executeAction() { | |||
| executingCustomAction = resolvedAction; | |||
There was a problem hiding this comment.
i'd move this into the try block, it will be more clear that it goes together with the reset in the finally block
Andarist
approved these changes
May 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR warns for improper imperative calls of built-in actions, which is a very common problem.
https://stately.ai/docs/actions#built-in-actions