Add checker timeout #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffa5
force-pushed
the
checker-timeout
branch
from
9e51ca4
to
75fe1f2
Compare
jonnadal
approved these changes
Mar 2, 2024
Comment on lines
-360
to
+361
| Some("check") => { | ||
| Some("check-bfs") => { |
There was a problem hiding this comment.
I'lll follow up w/ a commit to ensure the check option also works to avoid breaking bench.sh.
Comment on lines
+73
to
+84
| .spawn(move || loop { | ||
| let mut market = s1.market.lock(); | ||
| let now = SystemTime::now(); | ||
| if closing_time < now { | ||
| log::debug!("Reached timeout, triggering shutdown"); | ||
| market.open = false; | ||
| } | ||
| if !market.open { | ||
| break; | ||
| } | ||
| sleep(Duration::from_secs(1)); | ||
| }) |
There was a problem hiding this comment.
Potential future change: could sleep the delta at the beginning of the loop to avoid a wake-up every second.
There was a problem hiding this comment.
Definitely an improvement: #77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
This has the benefit of doing a 'clean' shutdown for each checker type, clearing work to be done, rather than stopping them mid-flow.
This might be updated when the checkers get unified with DPOR #7