Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack option #18

Merged
merged 7 commits into from
Apr 5, 2017
Merged

remove webpack option #18

merged 7 commits into from
Apr 5, 2017

Conversation

jescalan
Copy link
Member

@jescalan jescalan commented Feb 9, 2017

So the webpack option is not necessary at all. postcss-loader handles setting the file root, which the include plugin pulls from, so it doesn't need to get the root passed in by the user. Removing this option entirely should mean that everything works exactly the same.

This PR will also include the appendPlugin and prependPlugin convenience methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling df8a8d8 on updates into 8adbf5e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4e71840 on updates into 8adbf5e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7b8d2d5 on updates into 8adbf5e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 65fc3c0 on updates into 8adbf5e on master.

@jescalan jescalan merged commit 13aa421 into master Apr 5, 2017
@jescalan jescalan deleted the updates branch April 5, 2017 21:37
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 60a3310 on updates into 21cdc6c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d8d6df on updates into 21cdc6c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants