Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reshape to version 1.0.0 πŸš€ #84

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

marcus-n3rd
Copy link
Contributor

It seems that gatekeeper missed the 0.5.1 and 1.0.0 versions.

I only recently started using Spike and so all versions are the most recent, but when I tried compiling the site, it would throw the following:

βœ— ERROR
{ Error: Unrecognized node type: doctype
Node: {"type":"doctype","content":"<!DOCTYPE html>","location":{"line":1,"col":13}}

    at tree.reduce (/path/to/project/node_modules/reshape-code-gen/lib/index.js:95:11)

I had been comparing it to a working clone of spike-graphcms-netlify-example, but I noticed the reshape versions were significantly different and that sugarml was missing from the newer versions. I had attempted to use the master branch from this repo, but to no avail. After forking the repo and updating these two dependency versions, my site compiled as designed.

@jescalan jescalan merged commit 4ada83c into static-dev:master Aug 9, 2018
@jescalan
Copy link
Member

jescalan commented Aug 9, 2018

Great catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants