Skip to content

Commit

Permalink
fix unclear error messages, update spike-core to prerelease for testing
Browse files Browse the repository at this point in the history
  • Loading branch information
@jescalan
jescalan committed Feb 9, 2017
1 parent 04cdc84 commit 5960a59
Show file tree
Hide file tree
Showing 3 changed files with 845 additions and 727 deletions.
4 changes: 2 additions & 2 deletions bin/spike
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ var cli = new CLI()

cli.on('error', function (err) {
console.error(chalk.red('✗ ERROR'))
console.error(err.stack)
console.error(err.toString())
})

cli.on('warning', function (warn) {
console.warn(chalk.yellow('⚠ WARNING'))
console.warn(warn.stack)
console.warn(warn.toString())
})

cli.on('compile', function (res) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"chalk": "^1.1.3",
"inquirer": "^2.0.0",
"lodash.reduce": "^4.6.0",
"spike-core": "^0.13.3",
"spike-core": "next",
"universal-analytics": "^0.4.8"
},
"devDependencies": {
Expand Down

3 comments on commit 5960a59

@janwirth
Copy link

@janwirth janwirth commented on 5960a59 Feb 13, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only I had had the time to take a look, maybe I would have found it too 🙈

@jescalan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So actually this is a much deeper issue that I have a PR in to webpack core to fix right now.

webpack/webpack#4257

Hopefully this patch won't be necessary by the next stable release : )

@janwirth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, wow.

Please sign in to comment.