Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle rewrite challenge #286

Open
KarelJanVanHaute opened this issue Feb 15, 2024 · 0 comments
Open

Toggle rewrite challenge #286

KarelJanVanHaute opened this issue Feb 15, 2024 · 0 comments

Comments

@KarelJanVanHaute
Copy link
Contributor

KarelJanVanHaute commented Feb 15, 2024

Our toggle (accordion) component is now made with aria in mind and works ok. But there is a native construction for things like this. This should be better to use.

So the challenge is to rewrite it to use the

syntax.
Maybe we should also rename the toggleComponent to accordionComponent?

Some resources:
https://www.anysurfer.be/nl/documentatie/artikels/detail/inhoud-tonen-of-verbergen
https://gomakethings.com/creating-a-progressively-enhanced-accordion-with-the-details-and-summary-elements-and-11-lines-of-javascript/
https://daverupert.com/2019/12/why-details-is-not-an-accordion/
https://blog.learningtoo.eu/expanding-summary-details-accessibly
https://www.hassellinclusion.com/blog/accessible-accordions-part-2-using-details-summary/
https://fronteers.nl/blog/2019/12/maak-deze-kerst-een-vriend-blij-met-lekker-makkelijke-collapsibles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants