Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Wyam.Modules.* libraries to Wyam.* #295

Closed
daveaglick opened this issue May 22, 2016 · 3 comments
Closed

Rename Wyam.Modules.* libraries to Wyam.* #295

daveaglick opened this issue May 22, 2016 · 3 comments
Labels
🚨 Breaking Change Potentially breaks existing users General Enhancement New feature or request

Comments

@daveaglick
Copy link
Member

Strongly considering this change. It'll be breaking, but it'll also be a mechanical fix. Reasoning is now that we have other extension mechanisms like file providers, it makes sense that a single library might contain multiple types of things. For example, the Wyam.GitHub module will reference Octokit and will contain both GitHub based modules and GitHub file providers.

@daveaglick daveaglick added General Enhancement New feature or request 🚨 Breaking Change Potentially breaks existing users labels May 22, 2016
@daveaglick daveaglick changed the title Consider renaming Wyam.Modules.* libraries to Wyam.* Rename Wyam.Modules.* libraries to Wyam.* May 31, 2016
@daveaglick
Copy link
Member Author

FYI for any watchers - this change is definitely going to get made for 0.12.4-beta out this week. It's a pretty major breaking change because none of your NuGet references will continue to work. Thankfully the fix is very easy - just remove the .Modules part from the package name. I.e., Wyam.Modules.Markdown becomes Wyam.Markdown. This should make it easier to write and remember Wyam package names going forward and really should have been the convention from the beginning.

@LokiMidgard
Copy link
Contributor

In your release notes you said you renamed wyam.* to wyam.*.

@LokiMidgard
Copy link
Contributor

Not sure about this, but maybe you should also hide the Waym.Modules.* Packages from nuget search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 Breaking Change Potentially breaks existing users General Enhancement New feature or request
Development

No branches or pull requests

2 participants