Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link cover whole card, remove unnecesary aria #801

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Make link cover whole card, remove unnecesary aria #801

merged 7 commits into from
Aug 24, 2023

Conversation

omsaggau
Copy link
Contributor

No description provided.

@omsaggau omsaggau requested a review from ssb-cgn June 29, 2023 09:48
johnnadeluy
johnnadeluy requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are changes made to the props, the documentation for this component needs to be updated. Additionally, the tests are failing. Make sure to update and rerun those as well!

johnnadeluy
johnnadeluy approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎖Just remember to fix the lint test fail before merge

@omsaggau omsaggau merged commit 4fabfed into master Aug 24, 2023
5 checks passed
@omsaggau omsaggau deleted the MIMIR-1587_card-link branch August 24, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnadeluy johnnadeluy johnnadeluy approved these changes

@ssb-cgn ssb-cgn Awaiting requested review from ssb-cgn

Assignees

@johnnadeluy johnnadeluy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omsaggau @johnnadeluy