Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAT 23 update to latest spec #4

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

mmwinther
Copy link
Member

Summary of changes

Remove global default for assessment, this will be set in the application based on the dataset_state
Add version_description field
Add keywordfield
Add metadata prefix to all created/updated field names
Add contains_data_from/contains_data_until fields

Downstream

  • We bump both the MODEL_VERSION and the package major version since these changes will break compatibility. Backards compatibility will need to be handled in the datadoc app.
  • There are further changes to be made in the datadoc app under STAT-23.

@mmwinther mmwinther requested a review from a team October 4, 2022 06:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@BjornRoarJoneid BjornRoarJoneid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mmwinther

@mmwinther mmwinther merged commit 4c081ea into main Oct 4, 2022
@mmwinther mmwinther deleted the STAT-23-update-to-latest-spec branch October 4, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants