Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add summary_formula methods for lists and network.lists #54

Open
martinamorris opened this issue Jun 18, 2021 · 12 comments
Open

add summary_formula methods for lists and network.lists #54

martinamorris opened this issue Jun 18, 2021 · 12 comments
Assignees

Comments

@martinamorris
Copy link
Member

if it's not too much trouble...

@krivit
Copy link
Member

krivit commented Jun 18, 2021

There isn't one for lists, but there's one for network.lists, and it just evaluates the summary on each network in the list.

@martinamorris
Copy link
Member Author

hmm. i'm not having any luck with summary(network.list ~ terms):

data(samplk)
samp.list <- list(samplk1,samplk2)
samp.netlist <- network.list(samp.list)
summary.netlist <- summary(samp.netlist ~
                            Form(~edges) +
                            Diss(~edges))
Error: In term ‘Form (dynamic)’ (called from term ‘Form’ in package ‘tergm’): This term requires either dynamic data (network series or network dynamic or last toggle information) or for dynamic mode to be set (typically by passing ‘dynamic=TRUE)’ to the top-level function.

@krivit
Copy link
Member

krivit commented Jun 19, 2021

Right. This is because that method is defined in ergm, and treats each network individually; this is probably how it should be, since we shouldn't assume that the user wants to omit and condition on the first network, unless they actually use NetSeries.

We could implement a tsummary.formula() method analogous to tergm that would do that automatically.

@martinamorris
Copy link
Member Author

Can we make it an argument to summary, instead of a new function?

@krivit
Copy link
Member

krivit commented Jun 22, 2021

We'd have to do the same kind of switcheroo that we do with simulate_formula.network(), and that would probably require changing ergm, which we probably don't want to do for this release.

Longer term, we really need to figure out a better way to do this.

@krivit
Copy link
Member

krivit commented Jun 22, 2021

For this release, we may have to just tell people to use NetSeries(). I don't think we have time for anything else.

@martinamorris
Copy link
Member Author

They can also use networkDynamic

@krivit
Copy link
Member

krivit commented Jun 22, 2021

I am not 100% sure if there is an easy way to go from a network list to a networkDynamic. @skyebend ?

@martinamorris
Copy link
Member Author

summary_formula already works for networkDynamic

@CarterButts
Copy link

CarterButts commented Jun 22, 2021 via email

@krivit
Copy link
Member

krivit commented Jun 22, 2021

@CarterButts, oh, I missed that one. @martinamorris, sounds like we have a solution.

@krivit
Copy link
Member

krivit commented Jun 12, 2022

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants