correct strat mixing type toggleability check in discordBDStratTNT #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in discordBDStratTNT, to consider all free edges formerly only nondiscordant edges were considered, which could lead to incorrect behavior in some (generally rare) cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects discordBDStratTNT to consider all free edges when checking strat mixing type toggleability. Formerly only non-discordant edges were considered, which in rare cases could lead to incorrect behavior.
A related test has been added, and the run lengths of some other tests have been reduced to keep total test runtime from increasing.
The new test requires the updates in
ergm@ergm_block. There are no updates toergm.multi, but theergm.multi@ergm_blockbranch has been created to provide a version ofergm.multiwithergm@ergm_blockin its remotes field (so thatpakcan solve the dependencies).Once
ergm@ergm_blockis merged intoergm@master(see statnet/ergm#539), theergm@ergm_blockandergm.multi@ergm_blockremotes in this PR can be reverted toergm@masterandergm.multi@master, and theergm_blockbranches ofergmandergm.multican be deleted.There was an unrelated CMLE test failure (also present in
tergm@master), and I've increased the CMLE test tolerance in this branch to avoid that failure.