Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset Dependancy on statping.com #3

Open
adamboutcher opened this issue Aug 14, 2021 · 5 comments · Fixed by #40
Open

Asset Dependancy on statping.com #3

adamboutcher opened this issue Aug 14, 2021 · 5 comments · Fixed by #40
Assignees
@adamboutcher
Labels
Improvement An Improvement of an already implemented feature Migration Migrating over from statping to statping-ng New Feature A New Feature

Comments

@adamboutcher
Copy link
Collaborator

adamboutcher commented Aug 14, 2021 •
edited
Loading

There are many dependancies on assets hosted at statping.com especially on the front end, the wiki and readme.
@jemand771 jemand771 added the Migration Migrating over from statping to statping-ng label Aug 21, 2021
@adamboutcher
Copy link
Collaborator Author

Also readme deps on some wird places, we should copy any assets to the github.io website.

@adamboutcher
Copy link
Collaborator Author

Commit 4611f9e fixed the issue with the readme deps.

@adamboutcher
Copy link
Collaborator Author

Also deps in the main app, especially help and api qr code. See statping#1027.

Off the top of my head, some of these should be easily fixed, some others may take a bit of work eg the api qr code generation.

@adamboutcher adamboutcher added the New Feature A New Feature label Aug 25, 2021
@adamboutcher adamboutcher added the Improvement An Improvement of an already implemented feature label Sep 5, 2021
@adamboutcher adamboutcher self-assigned this Sep 5, 2021
@adamboutcher adamboutcher linked a pull request Sep 11, 2021 that will close this issue
Branding updates and CDN Changes. #40
Merged
@adamboutcher adamboutcher reopened this Sep 11, 2021
@adamboutcher
Copy link
Collaborator Author

There are still deps in the help section. However these should not load if you don't use it. We're aware the help section is crap.

Especially for cjx.io

I elected to move the statping.com assets to github, this reduces the number of requests to fewer 3rd parties.

@adamboutcher
Copy link
Collaborator Author

Email sending with "email" uses news.statping.com.
Newsletter signup probably should be removed.
Error reporting is via sentry.statping.com, probably be removed.

@adamboutcher adamboutcher mentioned this issue Oct 8, 2021
Closed
11 tasks
@adamboutcher adamboutcher mentioned this issue Dec 16, 2021
Merged
@adamboutcher adamboutcher mentioned this issue Jul 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamboutcher adamboutcher

Labels
Improvement An Improvement of an already implemented feature Migration Migrating over from statping to statping-ng New Feature A New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branding updates and CDN Changes.
2 participants
@adamboutcher @jemand771