Build changes #152
Merged
Build changes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jemand771 Can you double check I've not done anything stupid please? |
jemand771
approved these changes
Jul 26, 2022
|
Note that github uses the workflow files from the default branch (dev, which you're merging into) for all branches - not the one on the current branch A way to test this would be putting the workflow file on dev in a fork and trying the merge there, but I don't reaally have time for that right now :c |
|
I tested it on my own fork and it worked, I just wanted to make sure it looked sane to someone else incase I broke something obvious to others. Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable Mac M1 Builds and fix some issues with the Windows build not working correctly.
We do however lose Mac 32bit builds but I doubt they're needed.