Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced os system call with library #193

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

70B43r
Copy link

@70B43r 70B43r commented Nov 17, 2022

resolves #192

replaced system agnostic call with library

@adamboutcher
Copy link
Collaborator

Looking good, cany change you can fix your go.mod so it doesnt conflict? Looks like you're pushing the version back down to 1.16

@adamboutcher adamboutcher added Bug Something isn't working Improvement An Improvement of an already implemented feature labels Nov 18, 2022
@adamboutcher adamboutcher linked an issue Nov 18, 2022 that may be closed by this pull request
@adamboutcher adamboutcher linked an issue Nov 18, 2022 that may be closed by this pull request
@70B43r
Copy link
Author

70B43r commented Nov 18, 2022

Whoops ... was a bit late yesterday.
Should look better now.

@adamboutcher
Copy link
Collaborator

Looks great!

@adamboutcher adamboutcher merged commit 7abc4e8 into statping-ng:dev Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Improvement An Improvement of an already implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language dependent ping call fails to parse result ICMP Ping timeout setting not working on macos
2 participants