New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance GRPC Monitoring #806
Merged
hunterlong
merged 15 commits into
statping:dev
from
thatInfrastructureGuy:grpcCheckFixes
Oct 1, 2020
Merged
Enhance GRPC Monitoring #806
hunterlong
merged 15 commits into
statping:dev
from
thatInfrastructureGuy:grpcCheckFixes
Oct 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
thatInfrastructureGuy
force-pushed
the
grpcCheckFixes
branch
from
September 3, 2020 00:54
f2bc24d
to
904689b
Compare
Slack notifications did not work for me on latest dev branch but did work on |
@hunterlong Please let me know if you need me to do any changes. I am aiming to get feedback before major set of merge conflicts arise. Just trying to avoid same fate as #405 :) |
Merged, thanks @thatInfrastructureGuy I really appreciate it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
go test -v -run TestCheckGrpc ./...
Grpc.DialContext()
Docker Image for testing:
Note: If you are not sure if you have implemented GRPC health check endpoint, test it with grpcurl
Required Fields: