Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GRPC Monitoring #806

Merged
merged 15 commits into from Oct 1, 2020

Conversation

thatInfrastructureGuy
Copy link
Contributor

Goals:

  • Checks GRPC services without TLS certs
  • Checks GRPC services with TLS certs
  • Asserts against GRPC Health check for advance checks.
  • GRPC Health check is kept optional.
  • Comments and Hyperlinks added for GRPC health check toggle.
  • Updated default values for grpc check.
  • Add Tests go test -v -run TestCheckGrpc ./...
  • Bug Fix: Add timeout to Grpc.DialContext()

Docker Image for testing:

docker run -it -p 8080:8080 thatinfrastructureguy/statping:latest

Note: If you are not sure if you have implemented GRPC health check endpoint, test it with grpcurl

grpcurl grpc.domain.com:50051 grpc.health.v1.Health/Check

{
  "status": "SERVING"
}

Required Fields:

  1. Application URL domain.
  2. Port Number
  3. Verify SSL (Turn this flag on if you are serving via TLS).

screengrab.gif

@thatInfrastructureGuy thatInfrastructureGuy changed the title Enhance GRPC Checks Enhance GRPC Monitoring Sep 3, 2020
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
Signed-off-by: thatInfrastructureGuy <thatInfrastructureGuy@gmail.com>
@thatInfrastructureGuy
Copy link
Contributor Author

Slack notifications did not work for me on latest dev branch but did work on v0.90.64 hence, the image thatinfrastructureguy/statping:latest is built from v0.90.64

@thatInfrastructureGuy
Copy link
Contributor Author

@hunterlong Please let me know if you need me to do any changes. I am aiming to get feedback before major set of merge conflicts arise. Just trying to avoid same fate as #405 :)

@hunterlong hunterlong added this to Feature in Server/Backend Sep 19, 2020
@hunterlong hunterlong merged commit fccc559 into statping:dev Oct 1, 2020
@hunterlong
Copy link
Member

hunterlong commented Oct 1, 2020

Merged, thanks @thatInfrastructureGuy I really appreciate it.

@hunterlong hunterlong mentioned this pull request Oct 7, 2020
@thatInfrastructureGuy thatInfrastructureGuy deleted the grpcCheckFixes branch October 20, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Server/Backend
  
Feature
Development

Successfully merging this pull request may close these issues.

None yet

2 participants