Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on rand #93

Merged
merged 3 commits into from Jan 5, 2019
Merged

Update dependency on rand #93

merged 3 commits into from Jan 5, 2019

Conversation

ManifoldFR
Copy link
Contributor

This pull requests updates statrs' dependency on the rand random number generation crate. I re-ran the tests and benchmarks to check everything works, fixed up a couple deprecation warnings (that didn't appear when just doing cargo build).

Resolves #92

@dhardy
Copy link

dhardy commented Jan 4, 2019

I wonder if this is the correct solution, or if we should put out a compatibility bridge between 0.5 and 0.6.

Depending on rand 0.6.0 should be good enough here.

@ManifoldFR
Copy link
Contributor Author

The command cargo fmt --all -- --check returned 1 as an exit code in the CI, because of some formatting issue.

Copy link
Collaborator

@boxtown boxtown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@boxtown boxtown merged commit 79ea7fa into statrs-dev:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the dependency on rand
3 participants