Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In cubejs-schema-compiler joi@10.6.0 upgrade to joi@14.3.1 #59

Conversation

manojown
Copy link
Contributor

resolve #47

Fix dependency warning in schema compiler .

Current joi@10.6 version is deprecated so upgrade to latest joi@14.3.1 .

@paveltiunov
Copy link
Member

@manojown That was fast! 👍 Could you please confirm that $ npm test in schema compiler runs successfully?

@manojown
Copy link
Contributor Author

manojown commented Mar 29, 2019

hey @paveltiunov its failing by Error: connect ECONNREFUSED 127.0.0.1:5432 .
what other services need to start for cubejs-schema-compiler .? ( PostgreSQL port)

@manojown
Copy link
Contributor Author

@paveltiunov run npm test command and schema compiler runs successfully .
Screen Shot 2019-03-29 at 5 23 14 PM

@paveltiunov
Copy link
Member

@manojown Good to hear that you figured it out! Thanks for contributing this!

@paveltiunov paveltiunov merged commit f035531 into cube-js:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependency warning in schema compiler (joi)
2 participants