Test if the supplied log level is defined in node-syslog.

Remove eval()! :)
statsd · Jul 16, 2012 · 0638da7 · 0638da7
1 parent 73b8013
commit 0638da7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/exampleConfig.js b/exampleConfig.js
@@ -42,7 +42,7 @@ Optional Variables:
   log:              log settings [object, default: undefined]
     backend:        where to log: stdout or syslog [string, default: stdout]
     application:    name of the application for syslog [string, default: statsd]
-    level:          log level for syslog [string, default: LOG_INFO]
+    level:          log level for [node-]syslog [string, default: LOG_INFO]
 
 */
 {

diff --git a/lib/logger.js b/lib/logger.js
@@ -24,10 +24,13 @@ Logger.prototype = {
     } else {
       if (!type) {
         type = this.level
+        if (!this.util[type]) {
+          throw "Undefined log level: " + type;
+        }
       } else if (type == 'debug') {
         type = "LOG_DEBUG";
       }
-      this.util.log(eval("this.util." + this.level), msg);
+      this.util.log(this.util[type], msg);
     }
   }
 }