New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.js file watching broken on OSX #182
Comments
please provide the version of node.js that is installed on your system |
v0.8.12, also I meant to include this link previously:
(sorry) |
It was changed in pull request #145, because I'd suggest:
|
Implements fix as suggested by Peter Schuster in comment thread. Signed-off-by: ciaranj <ciaranj@gmail.com>
I've submitted a pull request with @peschuster ' s suggested fix. |
closing this since we have pull request #184 |
Implements fix as suggested by Peter Schuster and Daniel Schauenberg in comment thread. Signed-off-by: ciaranj <ciaranj@gmail.com>
Fixes Issues #182 - Broken config file watching.
Implements fix as suggested by Peter Schuster and Daniel Schauenberg in comment thread. Signed-off-by: ciaranj <ciaranj@gmail.com>
Fixes Issues statsd#182 - Broken config file watching.
commit: 19814bd appears to break OSX . The API call appears incorrect. Could be down to the version of node.js I'm using, but fs.watch takes function( event, filename_) [filename_ not present in OSX incidentally] not function( curr, prev ) as fs.watchFile does.
This means I see the following errors:
Now, I would provide a patch to fix it, but since the commit that introduces the changes gives no hints as to what was being fixed, I can't make sure that it remains fixed.
If I had to guess I'd say this is broken for everyone, but on Windows & Linux the second argument (filename) does actually exist so prev.ino resolves to undefined, rather than trying to find .ino on undefined as in my case (OSX)
The text was updated successfully, but these errors were encountered: