Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional graphite options to reduce overall stat counts when not needed #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeff-minard-ck
Copy link

Essentially, I was writing tons and tons of stats that I didn't need because of all the extra calculated stats that statsd::graphite pulls together. I wanted less, instead of commenting things out locally, I thought I'd turn them into options.

Three new options, pretty straight forward, see the diff and they are documented in the exampleConfig.js file.

@travisbot
Copy link

This pull request passes (merged cd9daa5 into 4e4ed79).

@mrtazz
Copy link
Member

mrtazz commented Jun 26, 2012

Great idea! Some corrections and performance improvements have been made in the graphite backend. Would you mind basing your Pull Request on top of those changes?

@jeff-minard-ck
Copy link
Author

So, I updated my master from etsy/master, then I merged the master into this branch (went cleanly) and I guess the pull request now shows as much? Give it a try.

@travisbot
Copy link

This pull request fails (merged 709c047 into 42ff275).

@jeff-minard-ck
Copy link
Author

No fair, it failed because github was busted...

Using worker: nodejs1.worker.travis-ci.org:travis-nodejs-1

$ cd ~/builds
$ git clone --depth=100 --quiet git://github.com/etsy/statsd.git etsy/statsd
fatal: The remote end hung up unexpectedly

Done. Build script exited with: 1

@mrtazz
Copy link
Member

mrtazz commented Jun 26, 2012

awesome, thanks. Will do.

@outmost
Copy link

outmost commented May 14, 2013

I'm looking into exactly the same issue - having lots of metrics calculated by StatsD that aren't required. Will this be added to the master in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants