Improved the quality of randomness used for sampling. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version had issues with rapidly creating and disposing of StatsdPipe instances. If, say, 100 were created in the same millisecond, they would all be given the same Random seed. In this version, we use ThreadStatic storage to reduce the number of Random instances created, maintain thread safety, and allow randomness to vary much more quickly that per-millisecond.
|
Nice addition, thanks for the patch! |
mrtazz
added a commit
that referenced
this pull request
Jul 31, 2012
Improved the quality of randomness used for sampling.
hbouvier
pushed a commit
to hbouvier/statsd
that referenced
this pull request
May 25, 2013
Improved the quality of randomness used for sampling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version had issues with rapidly creating and disposing of StatsdPipe instances.
If, say, 100 were created in the same millisecond, they would all be given the same Random seed.
In this version, we use ThreadStatic storage to reduce the number of Random instances created, maintain thread safety, and allow randomness to vary much more quickly than per-millisecond.