-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of IANA port assignment form #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and smooth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, left a few small comments.
8125 | ||
|
||
### Description | ||
Network daemon for collecting metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...and publishing to various metric collection systems or services"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly I've just found out the form box doesn't let us put anything extra onto this so I've gone back to "Network daemon for collecting metrics", we only get an extra 2 or 3 characters past that.
I've made the suggested changes, if anyone is able to re-review and make sure they're happy then that'd be awesome 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though I've never submitted one of these before so I'm not sure what level of detail they tend to look for. I assume we can resubmit if they want more clarification or additional info?
I'll be honest I have no idea if we can resubmit after, but I'd assume we can so we'll have to ride the boat and see! |
The application has been submitted for StatsD using the |
Application id is |
Sadly the application was declined, they had some specific issues with the application itself but also with the general use case. By the sounds of the response even a resubmission wouldn't really fit the port assignment use case for them. I'll post the specifics when I get back to my computer in a few days but the outlook doesn't look very promising. |
Below is the body of the email received by the IANA Services Specialist. It explains the reasons the IESG Expert gave for rejecting the application.
It sounds to me like they're pretty set against assigning a port to statsd's use case, unless anyone interprets this differently and thinks it's worth persuing more, I'll probably look to get the request closed by IANA. |
At least you've tried, /cc @natoscott I believe SELinux team will have no problems with assigning port type to statsd. Thanks for info! |
Thanks @lzap, please do let us know if this does happen, we'd be keen to know 😄 |
Closing as this was rejected by IANA/IESG. Would be great to see if SELinux can assign a port anyway, I'll leave the origina issue #682 open for now. |
@BlueHatbRit well it actually happened already in Fedora: fedora-selinux/selinux-policy@5fa8f7c And I asked my colleagues to backport this into RHEL8 line. https://bugzilla.redhat.com/show_bug.cgi?id=1746511 Thanks! |
I had a quick look at this and I think it could be salvaged (glad to help) but one thing that really worries me is complete lack of security. Versioning is also problematic. There is also an interesting problem that this is a one-way protocol and here we specify only the server-side behaviour. In this case it is pretty easy to flood the destination with too much traffic. How do large installations using statsd cope with this, preventing burst traffic hitting a single instance? |
Have you tried yourself? In case of UDP there is a buffer and all excessive traffic is simply dropped by the kernel. In case of TCP, the traffic will be slowed down by the protocol as it's guaranteed delivery. I believe statsd protocol/service is not different from pretty much any other service. But I guess it's the wrong thread for this discussion. |
I don't have the exact statistics, but I'd wager than 90% of installations use UDP, TCP feels very much like an addition just "because we can". As @lzap said with UDP the traffic is just dropped. Since StatsD is designed to be run internally and never be exposed to the internet, a lot of the responsibility is on the user to understand the load the spin up a new node as required if they wish to handle the load. If the sys admin wishes to scale up to manage additional load then there are systems out there for autoscaling but that really sits on an infrastructure level rather than with statsd itself. |
This is the initial draft of the IANA port assignment form. As you might be able to tell, I've not filled one of these out before so I may have missed the point on some of these questions, hence the request for comments and feedback.
In the markdown document I've only listed the questions that we are required to answer. Please see the full form here - https://www.iana.org/form/ports-services to see any questions that have been intentionally skipped. Would be great if someone could also check this in case I've missed something important!
Many of the questions refer to the protocol as opposed to the service.
ccing for review / input: @mheffner, @mrtazz, @lzap. Please feel free to pull in anyone else who might have experience and be interested in helping out.