Skip to content

Commit

Permalink
ENH: add Results wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
josef-pkt committed Sep 22, 2020
1 parent 91bc2d2 commit c3bd39d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
14 changes: 13 additions & 1 deletion statsmodels/miscmodels/ordinal_model.py
Expand Up @@ -15,6 +15,9 @@
from statsmodels.base.model import (
GenericLikelihoodModel, GenericLikelihoodModelResults)
from statsmodels.compat.pandas import Appender
# for results wrapper:
import statsmodels.regression.linear_model as lm
import statsmodels.base.wrapper as wrap


class OrderedModel(GenericLikelihoodModel):
Expand Down Expand Up @@ -371,7 +374,9 @@ def fit(self, start_params=None, method='nm', maxiter=500, full_output=1,
# TODO: temporary, needs better fix, modelwc adds 1 by default
ordmlefit.hasconst = 0

return ordmlefit
result = OrderedResultsWrapper(ordmlefit)

return result


class OrderedResults(GenericLikelihoodModelResults):
Expand Down Expand Up @@ -423,3 +428,10 @@ def llr_pvalue(self):
"""
# number of restrictions is number of exog
return stats.distributions.chi2.sf(self.llr, self.model.k_vars)


class OrderedResultsWrapper(lm.RegressionResultsWrapper):
pass


wrap.populate_wrapper(OrderedResultsWrapper, OrderedResults)
4 changes: 4 additions & 0 deletions statsmodels/miscmodels/tests/test_ordinal_model.py
Expand Up @@ -122,6 +122,10 @@ def test_results_other(self):
n, k = res1.model.exog.shape
assert_equal(self.resf.df_resid, n - (k + 2))

# check wrapper
assert resp.params.index.tolist() == resp.model.exog_names
assert resp.bse.index.tolist() == resp.model.exog_names


class TestLogitModel(CheckOrdinalModelMixin):

Expand Down

0 comments on commit c3bd39d

Please sign in to comment.