Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_diagnostic_count functions starting with "test_" should renamed #5019

Open
jbrockmendel opened this issue Aug 25, 2018 · 2 comments
Open

_diagnostic_count functions starting with "test_" should renamed #5019

jbrockmendel opened this issue Aug 25, 2018 · 2 comments

Comments

@jbrockmendel
Copy link
Contributor

No description provided.

@josef-pkt
Copy link
Member

why?
what's the story?

@jbrockmendel
Copy link
Contributor Author

Convention and clarity. The overwhelmingly common pattern is that test_foo refers to a unit test, while foo_test refers to a statistical test.

@jbrockmendel jbrockmendel mentioned this issue May 12, 2019
Open
jbrockmendel added a commit to jbrockmendel/statsmodels that referenced this issue Jun 4, 2019
@jbrockmendel
REF: fix non-idiomatic names, closes statsmodels#5019
3fe660d
@jbrockmendel jbrockmendel mentioned this issue Jun 4, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: fix non-idiomatic names, closes #5019 jbrockmendel/statsmodels
2 participants
@josef-pkt @jbrockmendel