-
Notifications
You must be signed in to change notification settings - Fork 2.9k
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improvements to new ARIMA-type estimators #6159
Comments
@ChadFulton I would like to work on this enhancement, would like to request some help in guiding to start working on this enhancement. Thank you |
@rajathpatel23 that would be great, thanks! There are a number of things here that I think should be pretty self-contained, including:
If you have a particular interest, I can go into more details. |
Hi Chad, How one can add examle Notebooks? Thanks, |
Three steps to add a notebook:
I like the format that @ChadFulton uses with the title. I used it here: https://github.com/statsmodels/statsmodels/blob/master/docs/source/_static/images/rolling_ls.png |
NB: The json file determines where the example notebook appears in the docs, so please add in the correct section. |
Hi Chad, |
That would be much appreciated, thanks! First, a little background (maybe you already know this, but just in case you haven't run into this feature before). In our models, all of the parameters are typically estimated by maximum likelihood. But in some cases, you might want to "fix" one of the parameters to a particular value, and then estimate the other parameters by maximum likelihood. A simple example is: endog = np.random.normal(size=100)
# AR(1) model with an intercept
mod = sm.tsa.SARIMAX(endog, order=(1, 0, 0), trend='c')
# Suppose we want to estimate the AR(1) coefficient, but we want to specify the intercept to be 0.5
with mod.fix_params({'intercept': 0.5}):
res = mod.fit()
print(res.summary()) this results in:
A more complete set of examples can be found in this notebook: https://www.statsmodels.org/stable/examples/notebooks/generated/statespace_fixed_params.html. This feature is available in state space models (and also in the new I think the easiest place to get started would be adding fixed parameters to the Hannan-Rissanen estimator, which is the To see why it is straightforward with OLS, consider the following regression equation:
If we want to fix
where we have created the new variable So basically, what I suggest is the following:
Also, for the first attempt, I would just raise a Thanks! |
Thank you Chad for this nice illustration. I will start working accordingly. |
Hi Chad, could you please help me how to identify the corresponding column when removing the parameter from the 2d array? |
Hi @ChadFulton, first time contributing here. I would like to help out if this issue is still open and active. I can pick up where @madhushree14 left off on #7202, or I can go on to work on GLS. Either way, I'd be curious to investigate the result difference on Brockwell and Davis example 6.6.3 next. |
Hi @jackzyliu, thanks, that would be much appreciated! I think we need fixed parameters for HR and/or innovations MLE before we can support fixed parameters for GLS, so I will ping #7202 / #7355 to see what the status is. In the meantime, if you have time/interest to take a look at the implementation of Hannan-Rissanen, that would be a great way to get into things here. Thanks again! |
Hello, I am looking for a good issue for my very first contribution to any Python module. As I used ARIMA several times before, and have background in econometric, this could be a good choice. Is there any open part of this task where I could contribute? Thanks for guidance. |
Collection of follow-ups to #5827. These can/should be broken out into individual PRs. Many are relatively straightforward and would make a good first PR.
General
sm.tsa.arima.ARIMA
works withfix_params
(it should fail except when the fit method isstatespace
).GLS
other_results
.include_constant
but not other trend specifications (e.g. that it is to maintain consistency with estimation methods with assumptions that require demeaned series).Hannan Rissanen
Innovations MLE
Innovations algorithm
The text was updated successfully, but these errors were encountered: