Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot_acf doesn't forward missing to acf #6209

Closed
david-waterworth opened this issue Oct 23, 2019 · 0 comments · Fixed by #6227
Closed

plot_acf doesn't forward missing to acf #6209

david-waterworth opened this issue Oct 23, 2019 · 0 comments · Fixed by #6227
Labels
comp-graphics comp-tsa type-enh
Milestone
0.11

Comments

@david-waterworth
Copy link

david-waterworth commented Oct 23, 2019 •
edited

plot_acf forwards its alpha, fft and unbiased arguments to acf(). However acf also accepts missing which isn't forwarded.

This means I cannot use plot_acf() on data with gaps (represented by NaN) since I cannot pass missing='conservative'

If I have time I'll create a pull request but I cannot promise when I'll get around to it.
bashtage added a commit to bashtage/statsmodels that referenced this issue Nov 5, 2019
@bashtage
ENH: Add missing keyword argument to plot_acf
a7cbb59 
Add missing
Restict most keyword to be keyword only

closes statsmodels#6209
@bashtage bashtage mentioned this issue Nov 5, 2019
Merged
4 tasks
bashtage added a commit to bashtage/statsmodels that referenced this issue Nov 5, 2019
@bashtage
ENH: Add missing keyword argument to plot_acf
33f6a63 
Add missing
Restrict most keyword to be keyword only

closes statsmodels#6209
bashtage added a commit to bashtage/statsmodels that referenced this issue Nov 5, 2019
@bashtage
ENH: Add missing keyword argument to plot_acf
de8529a 
Add missing
Restrict most keyword to be keyword only

closes statsmodels#6209
@bashtage bashtage added this to the 0.11 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp-graphics comp-tsa type-enh
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

ENH: Add missing keyword argument to plot_acf bashtage/statsmodels
2 participants
@david-waterworth @bashtage