Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG GenericLikelihoodModel does not propagate kwargs in __init__ #7049

Open
josef-pkt opened this issue Sep 21, 2020 · 0 comments
Open

BUG GenericLikelihoodModel does not propagate kwargs in __init__ #7049

josef-pkt opened this issue Sep 21, 2020 · 0 comments

Comments

@josef-pkt
Copy link
Member

I ran into the bug with hasconst that was not propagated
see #7035 (comment)

There might be other keywords that should be propagated, e.g.
I guess that the data handling treatment for extra arrays like offset does not work, which, I guess, breaks conversion to ndarray and inclusion in missing value handling.

currently GenericLikelihoodModel.__init__ just attaches everything self.__dict__.update(kwds)

However, if I just propagate all kwds to the super call, then unit tests for miscmodel TLinearModel fail.

This needs review and better separation of which keyword should be propagated to super.

partial fix in #7035: I explicitly propagate hasconst, but leave other kwds as it is currently done.

josef-pkt added a commit to josef-pkt/statsmodels that referenced this issue Sep 21, 2020
ricardozago pushed a commit to ricardozago/statsmodels that referenced this issue Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant