Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deprecate some links #8325

Closed
wants to merge 1 commit into from

Conversation

bashtage
Copy link
Member

Deprecate lower case links in favor of upper case links

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

Deprecate lower case links in favor of upper case links
@pep8speaks
Copy link

Hello @bashtage! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 139:5: E306 expected 1 blank line before a nested definition, found 0

@lgtm-com
Copy link

lgtm-com bot commented Jun 21, 2022

This pull request introduces 5 alerts when merging 737448d into edea9ca - view on LGTM.com

new alerts:

  • 5 for Wrong number of arguments in a call

@bashtage bashtage closed this Dec 9, 2022
@bashtage bashtage deleted the depr-lower-link branch December 9, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants