Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect pred #100

Closed
wants to merge 4 commits into from
Closed

Perfect pred #100

wants to merge 4 commits into from

Conversation

josef-pkt
Copy link
Member

detect perfect prediction in Logit and Probit in a callback for the optimizer and raise an exception

@josef-pkt
Copy link
Member Author

I don't like that we raise an exception and propagate it to the user without returning results.

I think the callback is useful and the exception there can stop the minimization that will go off to infinity until it hits maxiter or maximum function evaluation (maybe not in every optimizer).

One idea is to catch the state of the optimization, capture the exception in the callback and return the last results.

see #39 also discussions on the mailing list,

test case example was discussed in #66

@wesm
Copy link
Member

wesm commented Oct 31, 2011

Merged into master. A few rebase conflicts but I handled them carefully, don't think I screwed anything up

@wesm wesm closed this Oct 31, 2011
@bashtage bashtage added the rejected Used for PRs with changes that are not acceptable label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Used for PRs with changes that are not acceptable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants