STY: PEP-8 Cleanup #1346
STY: PEP-8 Cleanup #1346
Conversation
|
merge, ignore or extend to larger cleanup. |
| @@ -341,7 +341,7 @@ def q_stat(x,nobs, type="ljungbox"): | |||
| ret = nobs*(nobs+2)*np.cumsum((1./(nobs-np.arange(1, | |||
| len(x)+1)))*x**2) | |||
There was a problem hiding this comment.
looks like there are a lot more missing spaces in this module
There was a problem hiding this comment.
yeah i'll give it a once over
There was a problem hiding this comment.
pep8 doesn't complain about this. should it?
There was a problem hiding this comment.
which pep8, the check script? or the newest version of the PEP?
we follow space around operators except power, the PEP does not anymore
There was a problem hiding this comment.
Strike that. It does now.
|
A little more comprehensive now. I ignored whitespace between arithmetic operators in indexing. It's a personal preference. |
| @@ -790,7 +805,8 @@ def grangercausalitytests(x, maxlag, addconst=True, verbose=True): | |||
|
|
|||
| if x.shape[0] <= 3 * maxlag + int(addconst): | |||
| raise ValueError("Insufficient observations. Maximum allowable " | |||
| "lag is {0}".format(int((x.shape[0] - int(addconst)) / 3) - 1)) | |||
| "lag is {0}".format(int((x.shape[0] - int(addconst)) / | |||
| 3) - 1)) | |||
There was a problem hiding this comment.
intend to the matching opening bracket?
impossible to see where the 3 belongs
There was a problem hiding this comment.
That's what I had but flake8 complained. I agree it's better though.
for intend in continuation lines that isn't large enough. |
| @@ -186,24 +191,24 @@ def adfuller(x, maxlag=None, regression="c", autolag='AIC', | |||
| if regresults: | |||
| store = True | |||
|
|
|||
| trenddict = {None:'nc', 0:'c', 1:'ct', 2:'ctt'} | |||
| trenddict = {None: 'nc', 0: 'c', 1: 'ct', 2: 'ctt'} | |||
There was a problem hiding this comment.
I think that looks good,
the "stranger" thing was the space before the :
STY: PEP-8 Cleanup
What to do with one-line style fix commits?