Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug norm expan shapes #1403

Merged
merged 4 commits into from Feb 21, 2014

Conversation

Projects
None yet
1 participant
@josef-pkt
Copy link
Member

commented Feb 20, 2014

NormExpan has incorrect shapes with breaks with recent scipy.

This is a slightly different solution, than #1397 by @piannucci
(I guess it avoids args introspection in scipy)

plus some basic unittests for NormExpan.
I didn't find a Gram-Charlier expansion distribution in R seek. (either it doesn't exist or it has a different name)

plus small cleanup: move examples out of module

test coverage for the expansion is still low
I tried a few more things to check whether the results are roughly correct, limit on RMSE, check for fat tails if kurtosis > 0, check for asymmetry if skew > 0, but haven't added them. They would be very coarse checks that qualitatively the results look right.

related: Evgeni has Edgeworth Expansion in PR #1325 with more complete, explicit implementation of other distribution methods.

@josef-pkt josef-pkt added PR labels Feb 20, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2014

python 3 has an unrelated test failure
in families test_link

Arrays are not almost equal to 8 decimals
 ACTUAL: 2476734513.8831224
 DESIRED: 2476734513.883122

sounds strange (that would require 18 significant digits) ?

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2014

supersedes #1397

ready to merge
There is still a lot to clean up and to increase test coverage, but I want to work on other things.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2014

rebased and force pushed

josef-pkt added a commit that referenced this pull request Feb 21, 2014

Merge pull request #1403 from josef-pkt/BUG_NormExpan
BUG Bug norm expan shapes closes #1397

@josef-pkt josef-pkt merged commit 1812c96 into statsmodels:master Feb 21, 2014

1 check passed

default The Travis CI build passed
Details
@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2014

tested with scipy 0.13.3, no failures or errors

merging

@josef-pkt josef-pkt deleted the josef-pkt:BUG_NormExpan branch Feb 21, 2014

@josef-pkt josef-pkt added the PR label Mar 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.