Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: travis.yml change language to python #1503

Closed

Conversation

josef-pkt
Copy link
Member

try to fix #1502

coverall file access is broken

@josef-pkt
Copy link
Member Author

switching to language python didn't help for coveralls, but the tests ran without problems

@josef-pkt
Copy link
Member Author

The last commit "adjust coverage path" needs to be reverted because it picks up the entire sandbox and lowers our coverage level even further.

I'm giving up on this for now. I have no clue and there are many other repos affected in the same way
(nipy/nipype uses python-coveralls not coveralls)
scipy also doesn't have files for example https://coveralls.io/files/159716513

https://www.google.ca/search?q=coveralls+isn%27t+available+on+GitHub.+Either+it%27s+been+removed%2C+or+the+repo+root+directory+needs+to+be+updated.&oq=coveralls+isn%27t+available+on+GitHub.+Either+it%27s+been+removed%2C+or+the+repo+root+directory+needs+to+be+updated.&aqs=chrome..69i57.405j0j7&sourceid=chrome&espv=210&es_sm=93&ie=UTF-8

@jseabold
Copy link
Member

Can you add

omit = 
    */statsmodels/sandbox*

to the config file and see if that helps for the sandbox issue?

@josef-pkt
Copy link
Member Author

I don't want to exclude the entire sandbox.

The current setting in master actually works pretty well because it ignores all modules that are not run at all during the nosetests. That excludes all the files that are in the sandbox that are currently deadweight, but includes the parts that are in the sandbox because of missing final cleanup and move.
(For example Evgenyi adjusted his changes in scipy.stats.distributions to accommodate my structure of subclasses in the sandbox that have unit tests and failed.)

@jseabold
Copy link
Member

Well, if the code is tested, move it out of the sandbox.

@josef-pkt
Copy link
Member Author

my previous comments referred to the unittests itself

But for coverage it's similar, I do check the coverage when I'm working on modules in the sandbox and if there are issues for them. (mutliplecomparison, gmm were the latest cases)

@jseabold
Copy link
Member

jseabold commented Apr 3, 2014

I assume this is fixed elsewhere now. Close?

@jseabold
Copy link
Member

jseabold commented Apr 3, 2014

Closing this. Reopen if necessary.

@jseabold jseabold closed this Apr 3, 2014
@josef-pkt josef-pkt deleted the fix_coveralls_travisci branch July 27, 2015 11:36
@bashtage bashtage added the rejected Used for PRs with changes that are not acceptable label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected Used for PRs with changes that are not acceptable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coveralls coverage report for files is broken
3 participants