Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotplot kshedden rebased of 1294 #1681

Merged
merged 20 commits into from May 21, 2014
Merged

Dotplot kshedden rebased of 1294 #1681

merged 20 commits into from May 21, 2014

Conversation

josef-pkt
Copy link
Member

rebased version of pull #1294

Only one merge conflict in version0.6.rst

ready to merge if TravisCI is green in all pythons

@kshedden @josef-pkt
initial commit
344c2d4
@kshedden @josef-pkt
Rename stripe to striped
8ca8b3d
@kshedden @josef-pkt
Rename dotplot.py to dotplots.py
2bff9d3
@kshedden @josef-pkt
Wrapped matplotlib import in try
cf7ef94
@kshedden @josef-pkt
Major changes to interface -- not ready for review
45d54b9
@kshedden @josef-pkt
Add tests
c5e2832
@kshedden @josef-pkt
Finish interface rewrite, add vertical option, many other fixes
9da44d1
@kshedden @josef-pkt
Fix import in test script
1f16ad5
@kshedden @josef-pkt
Place tests in function
86f90e8
@kshedden @josef-pkt
Disable test
27abe35
@kshedden @josef-pkt
Improced handling of non-ndarray inputs
220b38e
@kshedden @josef-pkt
Removed pdf output from dotplot tests
fe0e304
@kshedden @josef-pkt
Added styles_order argument to allow order of stacked data to be spec…
b6de71d 
…ified; reintroduced option for tests to output to pdf (but switched off).
@kshedden @josef-pkt
Changed stacking order top top->bottom on horizontal plots
79e0cc3
@kshedden @josef-pkt
Added release text for dotplot
f13f0ff
@kshedden @josef-pkt
Added examples to docstring
0cbc271
@kshedden @josef-pkt
Added examples to docstring, edited release notes
04e6d27
@kshedden @josef-pkt
Rename dotplot to dot_plot; edit matplotlib import
3695467
@kshedden @josef-pkt
Update a few places dotplot to dot_plot in comments
d3f1750
@josef-pkt
Copy link
Member Author

This is not on common py2 py3 codebase yet. Needs fixing for python 3

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) when pulling d3f1750 on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

@josef-pkt
Copy link
Member Author

py3 compat is easy
python 2.6 doesn't have dictionary comprehension
(some changes could be reversed later, looks prettier without py 2.6 compatibility)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) when pulling b92bddd on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

josef-pkt
josef-pkt reviewed May 21, 2014
View reviewed changes
statsmodels/graphics/dotplots.py
horizontal=True, ax=None):
"""
Produce a dotplot similar in style to those in Cleveland's
"Visualizing Data" book. These are also known as "forest plots".
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary line should be one line

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) when pulling 2215682 on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

josef-pkt added a commit that referenced this pull request May 21, 2014
@josef-pkt
Merge pull request #1681 from josef-pkt/dotplot_kshedden_rebased
bbb0f8d 
ENH: add graphics dotplot
@josef-pkt josef-pkt merged commit bbb0f8d into statsmodels:master May 21, 2014
@josef-pkt josef-pkt deleted the dotplot_kshedden_rebased branch May 21, 2014 21:08
@josef-pkt josef-pkt mentioned this pull request May 21, 2014
Closed
@josef-pkt josef-pkt added this to the 0.6 milestone May 21, 2014
PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014
@josef-pkt
Merge pull request statsmodels#1681 from josef-pkt/dotplot_kshedden_r…
f7cb269 
…ebased

ENH: add graphics dotplot
@josef-pkt josef-pkt mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp-graphics type-enh
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josef-pkt @coveralls @kshedden