-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add cov_type fixed_scale to linear model #2137
Conversation
f9674e8
to
bca64ba
Compare
bca64ba
to
bb22420
Compare
Thanks for putting this in!!! As a unit test ... how about taking the example from |
@cdeil I added one set of unit tests from the scipy curve_fit tests. Thanks for the suggestion. |
I would like to leave the loglike refactoring to another PR, which means loglike and llf are not correct for fixed scale. merge as is ? |
Looks good to me: 👍 to merge. |
only two merges behind master, merging as is |
ENH: add cov_type fixed_scale to linear model closes #2142
@ceil Thanks for the feedback that llf/loglike are independent of the cov_type is "not nice" |
closes #2142 (I opened that issue for the record and to link to the mailing list discussions)
cov_type that allows fixing the scale in the linear model.
main use_case is when weights in WLS are actual inverse variances
see discussions on mailing list
Todo:
DONE except for llf/loglike which needs refactoring, in all 3 linear regression models
Questions:
Should we change the default to
use_t=False
? answer on mailing list: YesI think so, but IIRC we don't do it now as part of cov_type. (
use_t
was part of cov_type but is now mostly a separate, independent keyword.)correction: we already have
use_t=False
as default for every cov_type except'nonrobust'
, set inRegresssionResults.__init__
- nothing to do in this PRDo we want to overwrite the
scale
attribute?It's not necessary for cov_params and a bit of a pain to change - issues for unrelated refactoring.
skip this for now. this depends on other uses of the scale attribute
Follow-up question
Where do we put the relevant chisquare gof test, which only applies in the case of
fixed scale
?